Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduce Entry::getItem optimization in next api/abi release. #769

Closed
mgautierfr opened this issue Mar 15, 2023 · 3 comments · Fixed by #836
Closed

Reintroduce Entry::getItem optimization in next api/abi release. #769

mgautierfr opened this issue Mar 15, 2023 · 3 comments · Fixed by #836
Assignees
Milestone

Comments

@mgautierfr
Copy link
Collaborator

PR #768 remove interesting optimization but it was necessary as the change introduced a ABI break.
We should reintroduce it in the next release of libzim with ABI break

@kelson42 kelson42 added this to the 8.2.0 milestone Mar 17, 2023
@kelson42 kelson42 self-assigned this Mar 17, 2023
@kelson42
Copy link
Contributor

kelson42 commented Apr 1, 2023

@mgautierfr I'm not sure there is anything to do here as you have made 8.1.1 in a branch?!

@mgautierfr
Copy link
Collaborator Author

This is just a reminder to not forget to reintroduce the change.
We could reintroduce it right now, it it would force us to make a version 9.
As this change is just a really small optimization, I prefer to postpone it and make it when other change forces us to have a major version change.

@mgautierfr mgautierfr modified the milestones: 8.2.0, 9.0.0 Apr 3, 2023
@kelson42 kelson42 modified the milestones: 10.0.0, 9.0.0 Sep 30, 2023
@kelson42
Copy link
Contributor

@mgautierfr We should really do that right now IMO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants