You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Since 3.3.0, the reencode function (or more exactly the private _build_ffmpeg_args function) is auto-magically adding the -threads argument to the passed ffmpeg_args:
Since 3.3.0, the
reencode
function (or more exactly the private_build_ffmpeg_args
function) is auto-magically adding the-threads
argument to the passedffmpeg_args
:python-scraperlib/src/zimscraperlib/video/encoding.py
Lines 22 to 26 in 453afc0
This causes issues like openzim/kolibri#89 where since we are retrying to encode the video multiple times, the same dictionary is modified twice.
I think that
reencode
function should not modify the passed dictionary but its own copy.I add this to the
3.4.0
for now, but clearly deserve a3.3.1
patch I think.WDYT?
The text was updated successfully, but these errors were encountered: