Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consider if spring is ok dependency #27

Open
codefromthecrypt opened this issue Oct 18, 2019 · 1 comment
Open

consider if spring is ok dependency #27

codefromthecrypt opened this issue Oct 18, 2019 · 1 comment

Comments

@codefromthecrypt
Copy link
Member

We currently have a hard-coded way to setup zipkin config. If spring is ok to run inside cassandra (just spring is needed, not spring boot), we can configure all the things, including sampling rate etc, without a lot of copy/paste. For example, this is how the Dubbo framework configures itself..

https://github.com/openzipkin/brave/tree/master/spring-beans

cc @jake-codes @llinder @michaelsembwever
@codefromthecrypt
Copy link
Member Author

note: this could also be done as a separate module really..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@codefromthecrypt