Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UnsafeSpan #651

Open
codefromthecrypt opened this issue Mar 12, 2018 · 0 comments
Open

UnsafeSpan #651

codefromthecrypt opened this issue Mar 12, 2018 · 0 comments

Comments

@codefromthecrypt
Copy link
Member

It would be nice to make an unsafe variant of Span, which requires external synchronization and doesn't plan on out-of-band updates. This will make it more efficient to implement layers like Census (#626) who always pass around a span. Also, it will be more efficient for loops or synchronous calls. For example, message tracing or AOP generated spans.

UnsafeSpan.customizer() will likely need to be thread-safe and checked before finish is done. It may be easiest to re-use RealSpanCustomizer for this, then just grab any data before finish.

This layers on #650 but will need some other work, for example, some refactoring about how we share trace-scoped clocks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant