Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm-charts avoiding autoinject #5

Open
jcchavezs opened this issue Jan 31, 2022 · 1 comment
Open

helm-charts avoiding autoinject #5

jcchavezs opened this issue Jan 31, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@jcchavezs
Copy link
Contributor

jcchavezs commented Jan 31, 2022

Right now zipkin deployments by default avoid istio pod injection, while this is right or not we should be able to add some rationale to such behaviour.

https://github.com/openzipkin/zipkin/blob/master/charts/zipkin/values.yaml#L37

Ping @jonkerj @chirauki

@jcchavezs jcchavezs added the bug Something isn't working label Jan 31, 2022
@jonkerj
Copy link
Contributor

jonkerj commented Feb 1, 2022

I'm a bit divided on wether or not this default makes sense. On the one hand I think in a typical situation, Zipkin needs to be outside of the mesh (since you are debugging/tracing the mesh itself). This makes it usable for the first time users. On the other, if we leave the annotations dicts empty by default, it leaves a bit more freedom for the novices.

I tend to prefer the former (as it is our situation), but I agree it should be documented/explained in the README

@codefromthecrypt codefromthecrypt transferred this issue from openzipkin/zipkin Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants