Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setting to disable shared spans (joins) in tracer. #125

Open
tylerbenson opened this issue Jul 11, 2018 · 2 comments
Open

Add setting to disable shared spans (joins) in tracer. #125

tylerbenson opened this issue Jul 11, 2018 · 2 comments

Comments

@tylerbenson
Copy link

Other tracer implementations include a setting to force client and server spans to have different spanId's. In Go the setting is WithSharedSpans(false) and in Java it's supportsJoin(false).

There should be something similar in ruby.

This is important because zipkin traces may be reported to non-zipkin backends that might not support the concept of joining spans.

@dpdpbj
Copy link

dpdpbj commented Nov 22, 2019

agree. I encountered a problem when use jaeger client send request to zipkin client, and the backend server is jaeger server. It will report the duplicate span ID.

@jcchavezs
Copy link

I think the main reason here is feature parity with other languages. Whether Jaeger supports it or not might be discussed in their forums.

@dp9463 are you up for a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants