Handle no readme bug #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @kibertoad - came across an interesting bug while building a module that uses this as the source:
When you opt to not have a
README.mdgenerated by Terraform, theoutputfor that file isn't populated ( ... obviously 🤷♀), which in turn generates a breaking error and terminates an Execution.With this fix (see
outputs.tf) I use the try function to attempt get a value and default tonullif nothing is available.I've also moved the contents of
locals.tfintovariables.tfas per standard module structure and added anoverview.pngto make it clear which resources are added.[EDIT] I've also updated the version references from
1.1.0to1.1.1in preparation for the next tag.