Skip to content

Latest commit

 

History

History
164 lines (127 loc) · 6.93 KB

CONTRIBUTING.md

File metadata and controls

164 lines (127 loc) · 6.93 KB
Raw

How to Contribute

Catalogd is Apache 2.0 licensed and accepts contributions via GitHub pull requests. This document puts together some guidelines on how to make contributions to Catalogd and provides contacts to get in touch with the Catalogd maintainers and developers. To learn more about Catalogd and how it fits into OLM V1, please refer to Operator Lifecycle Manager (OLM) V1 Product Requirements Document (PRD).

Certificate of Origin

By contributing to this project you agree to the Developer Certificate of Origin (DCO). This document was created by the Linux Kernel community and is a simple statement that you, as a contributor, have the legal right to make the contribution. See the DCO file for details.

Communication Channels

Getting started

  • Fork the repository on GitHub.
  • Clone the repository onto your local development machine via git clone https://github.com/{$GH-USERNAME}/catalogd.git.
  • Add operator-framework/catalogd upstream remote by running git remote add upstream https://github.com/operator-framework/catalogd.git.
  • Create a new branch from the default main branch and begin development in the area of your interest.

Reporting bugs and creating issues

Any new contribution should be linked to a new or existing github issue in the Catalogd project. This issue can help track work, discuss the design and implementation, and help avoid duplicate efforts of multiple people working on the same issue. Trivial changes, like fixing a typo in the documentation, do not require the creation of a new issue but can be linked to an existing issue if it exists.

Proposing larger changes to the Catalogd project may require an enhancement proposal, or some documentation, before being considered. The maintainers typically use Google Docs and an RFC process to write design drafts for any new features. If you're interested in proposing ideas for new features, you can use the RFC Template to write an RFC and place it in the Design Docs Folder.

Any changes to Catalogd's existing behavior or features, APIs, or changes and additions to tests do not require an enhancement proposal.

Contribution flow

Below is a rough outline of what a contributor's workflow looks like:

  • Identify an existing issue or create a new issue. If you're new to Catalogd and looking to make a quick contribution and ramp up on the project, a good way to do this is to identify good-first-issues from Catalogd Github Issues by using the filter by label and search for "good first issue". Also, please feel empowered to work on other issues that interest you which are not good first issues.
  • Create a new branch from the branch you would like to base your contribution from. Typically, this is the main branch.
  • Create commits that are of logical units.
  • Commit your changes and make sure to use commit messages that are in proper format following best practices and guidelines for git commit messages (see below).
  • Once you've committed your changes, push the new branch that contains your changes to your personal fork of the repository.
  • Submit a pull request to operator-framework/catalogd repository.
  • Respond to feedback from the Catalogd maintainers and community members and address any review suggestions. The PR must receive an approval from at least one Catalogd maintainer.

Format of the commit message

We follow a rough convention for commit messages that is designed to answer two questions: what changed and why. The subject line should feature the what and the body of the commit should describe the why.

(feature): create a minimal client library

- Fixes #10
- Add unit tests for the client library

The format can be described more formally as follows:

<subsystem>: <what changed>
<BLANK LINE>
<why this change was made>
<BLANK LINE>
<footer>

The first line is the subject and should be no longer than 70 characters, the second line is always blank, and other lines should be wrapped at 80 characters. This allows the message to be easier to read on GitHub as well as in various git tools.

Code Review

Creating PRs with a reasonable title and description can go a long way with helping the PR through the review process.

When opening PRs that are in a rough draft or work-in-progress (WIP) state, prefix the PR description with WIP: ... or create a draft PR. This can help save reviewer's time by communicating the state of a PR ahead of time. Draft/WIP PRs can be a good way to get early feedback from reviewers on the implementation, focusing less on smaller details, and more on the general approach of changes.

When contributing changes that require a new dependency, check whether it's feasible to directly vendor that code without introducing a new dependency.

Currently, PRs require at least one approval from a Catalogd maintainer in order to get merged.

Code style

The coding style suggested by the Golang community is used throughout the Catalogd project:

In addition to the linked style documentation, Catalogd formats Golang packages using the golangci-lint tool. Before submitting a PR, please run make lint locally and commit the results. This will help expedite the review process, focusing less on style conflicts, and more on the design and implementation details.

Please follow this style to make the Catalogd project easier to review, maintain and develop.

Documentation

If a contribution changes the existing APIs or user interface it should include sufficient documentation to explain the new or updated features.

The Catalogd documentation is primarily housed at the root-level README, and there is also demo located in the catalog docs directory. Any changes to the existing APIs or the user interface would require updating this demo as well.

Additional resources

If you would like to view the roadmap of OLMV1, please refer to Operator Lifecycle Manager (OLM) V1 Roadmap for any other potential areas of interest in this space.

Thank you for your interest in contributing to the Catalogd project.