From efa526232445cb14390220c2dff1138876e7c8f4 Mon Sep 17 00:00:00 2001
From: Bryce Palmer <bpalmer@redhat.com>
Date: Fri, 8 Sep 2023 12:45:17 -0400
Subject: [PATCH] rebase

Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
---
 cmd/manager/main.go  | 51 +++++++++++++++++++-------------------------
 pkg/server/server.go | 34 -----------------------------
 2 files changed, 22 insertions(+), 63 deletions(-)
 delete mode 100644 pkg/server/server.go

diff --git a/cmd/manager/main.go b/cmd/manager/main.go
index 81c7b19c..0a3316d6 100644
--- a/cmd/manager/main.go
+++ b/cmd/manager/main.go
@@ -43,7 +43,7 @@ import (
 	corecontrollers "github.com/operator-framework/catalogd/pkg/controllers/core"
 	"github.com/operator-framework/catalogd/pkg/features"
 	"github.com/operator-framework/catalogd/pkg/profile"
-	"github.com/operator-framework/catalogd/pkg/server"
+	catalogdserver "github.com/operator-framework/catalogd/pkg/server"
 	"github.com/operator-framework/catalogd/pkg/storage"
 
 	//+kubebuilder:scaffold:imports
@@ -126,37 +126,30 @@ func main() {
 		os.Exit(1)
 	}
 
+	var localStorage storage.Instance
 	if features.CatalogdFeatureGate.Enabled(features.HTTPServer) {
-		metrics.Registry.MustRegister(server.ApdexTargetMetric, server.RequestDurationMetric)
-	}
-
-	if err := os.MkdirAll(storageDir, 0700); err != nil {
-		setupLog.Error(err, "unable to create storage directory for catalogs")
-	}
-<<<<<<< HEAD
-	localStorage := storage.LocalDir{RootDir: storageDir}
-	shutdownTimeout := 30 * time.Second
-	catalogServer := server.Server{
-		Kind: "catalogs",
-		Server: &http.Server{
-			Addr:         catalogServerAddr,
-			Handler:      localStorage.StorageServerHandler(),
-			ReadTimeout:  5 * time.Second,
-			WriteTimeout: 10 * time.Second,
-		},
-		ShutdownTimeout: &shutdownTimeout,
-=======
+		metrics.Registry.MustRegister(catalogdserver.RequestDurationMetric)
 
-	if features.CatalogdFeatureGate.Enabled(features.HTTPServer) {
-		metrics.Registry.MustRegister(server.RequestDurationMetric)
-		srv := server.Instance{StorageDir: storageDir}
-		mgr.AddMetricsExtraHandler("/catalogs/", server.AddMetricsToHandler(srv.CatalogServerHandler()))
->>>>>>> dbb9540 (remove apdex target gauge, increase histogram buckets)
+		if err := os.MkdirAll(storageDir, 0700); err != nil {
+			setupLog.Error(err, "unable to create storage directory for catalogs")
+		}
+		localStorage = storage.LocalDir{RootDir: storageDir}
+		shutdownTimeout := 30 * time.Second
+		catalogServer := server.Server{
+			Kind: "catalogs",
+			Server: &http.Server{
+				Addr:         catalogServerAddr,
+				Handler:      catalogdserver.AddMetricsToHandler(localStorage.StorageServerHandler()),
+				ReadTimeout:  5 * time.Second,
+				WriteTimeout: 10 * time.Second,
+			},
+			ShutdownTimeout: &shutdownTimeout,
+		}
+		if err := mgr.Add(&catalogServer); err != nil {
+			setupLog.Error(err, "unable to start catalog server")
+			os.Exit(1)
+		}
 	}
-	if err := mgr.Add(&catalogServer); err != nil {
-		setupLog.Error(err, "unable to start catalog server")
-		os.Exit(1)
-
 
 	if err = (&corecontrollers.CatalogReconciler{
 		Client:   mgr.GetClient(),
diff --git a/pkg/server/server.go b/pkg/server/server.go
deleted file mode 100644
index c0af72a5..00000000
--- a/pkg/server/server.go
+++ /dev/null
@@ -1,34 +0,0 @@
-package server
-
-import (
-	"io/fs"
-	"net/http"
-	"os"
-)
-
-type Instance struct {
-	StorageDir string
-}
-
-func (i Instance) CatalogServerHandler() http.Handler {
-	return http.StripPrefix("/catalogs/", http.FileServer(http.FS(&filesOnlyFilesystem{os.DirFS(i.StorageDir)})))
-}
-
-type filesOnlyFilesystem struct {
-	FS fs.FS
-}
-
-func (f *filesOnlyFilesystem) Open(name string) (fs.File, error) {
-	file, err := f.FS.Open(name)
-	if err != nil {
-		return nil, err
-	}
-	stat, err := file.Stat()
-	if err != nil {
-		return nil, err
-	}
-	if !stat.Mode().IsRegular() {
-		return nil, os.ErrNotExist
-	}
-	return file, nil
-}