Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metrics to the Storage implementation #127

Closed
everettraven opened this issue Aug 1, 2023 · 3 comments · Fixed by #156
Closed

Add metrics to the Storage implementation #127

everettraven opened this issue Aug 1, 2023 · 3 comments · Fixed by #156
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Milestone

Comments

@everettraven
Copy link
Collaborator

everettraven commented Aug 1, 2023

As a follow up to #113 we need to add metrics to assess the health of the HTTP server. The method we are planning to use for assessing the health of the service is the Apdex Score, which will require the implementation of 2 specific metrics:

  • Response time/duration
  • Response codes

Acceptance Criteria:

  • The Storage implementation is updated to produce the above metrics
  • Nice to have: Grafana dashboard to show graphs for the above metrics and the apdex score calculation
@ncdc
Copy link
Member

ncdc commented Aug 1, 2023

Rather than recording 5xx error counts, it might be better to record all response codes?

@everettraven
Copy link
Collaborator Author

Rather than recording 5xx error counts, it might be better to record all response codes?

Good point. Will update the description

@joelanford joelanford modified the milestones: v0.5.0, v0.6.0 Aug 15, 2023
@everettraven everettraven added kind/feature Categorizes issue or PR as related to a new feature. blocked good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Aug 21, 2023
@everettraven
Copy link
Collaborator Author

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants