Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up to-do list for #135 #142

Closed
anik120 opened this issue Aug 16, 2023 · 4 comments
Closed

Follow up to-do list for #135 #142

anik120 opened this issue Aug 16, 2023 · 4 comments

Comments

@anik120
Copy link
Collaborator

anik120 commented Aug 16, 2023

PR #135

@anik120
Copy link
Collaborator Author

anik120 commented Aug 16, 2023

Use Patch in controller instead of Update

@anik120
Copy link
Collaborator Author

anik120 commented Aug 16, 2023

Handle

  1. updates to catalog image content (newer fbc in remote)
  2. updates to spec change (new image in spec)

Steve's comment

@anik120
Copy link
Collaborator Author

anik120 commented Aug 28, 2023

Use cmp.Diff instead of individual Ginkgo checks where possible

@everettraven
Copy link
Collaborator

@anik120 can we close this issue? #135 was closed in favor of other PRs that merged

@ncdc ncdc closed this as completed Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants