Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should we continue to remove the olm.bundle.object bundle property for the HTTP server? #147

Closed
everettraven opened this issue Aug 28, 2023 · 2 comments
Closed

Should we continue to remove the olm.bundle.object bundle property for the HTTP server? #147

everettraven opened this issue Aug 28, 2023 · 2 comments

Comments

@everettraven
Copy link
Collaborator

Creating this issue to continue discussion of https://github.com/operator-framework/catalogd/pull/144/files#r1304851060
@everettraven everettraven mentioned this issue Aug 28, 2023
Merged
@joelanford
Copy link
Member

We should leave the olm.bundle.object properties in the blobs that we serve from the catalogd HTTP server. IMO, we should not merge #144 until it stores the blobs untouched.

Reasoning (that I also commented in the PR): I don't think disk space is a concern. All of the CPU used for deserialization/reserialization to filter that property out is more of a concern.

@anik120
Copy link
Collaborator

anik120 commented Aug 30, 2023

This has been removed.

@anik120 anik120 closed this as completed Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@joelanford @anik120 @everettraven