Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create an unpacking interface #52

Closed
everettraven opened this issue Apr 21, 2023 · 0 comments · Fixed by #65
Closed

Create an unpacking interface #52

everettraven opened this issue Apr 21, 2023 · 0 comments · Fixed by #65

Comments

@everettraven
Copy link
Collaborator

everettraven commented Apr 21, 2023

Add a Rukpak-like spec.source union type to the Catalog API, which would allow catalog filesystems to be sourced in a variety of ways. It would also give catalogd developers an extensible API surface to add new source mechanisms in the future.

The above quote was an idea mentioned in the OLMv1 Milestone 3 ideation discussion. We should implement an unpacking interface that allows us to easily support different sources of information for catalogs

An example of what this could look like on a CatalogSource CR in yaml:

apiVersion: catalogd.operatorframework.io/v1beta1
kind: CatalogSource
metadata: 
  name: catalogsource-sample
spec:
  source:
    type: catalogd.source.image
    image: quay.io/operatorhubio/catalog:latest

Acceptance Criteria:

  • Unit tests
  • An interface implemented for an unpacking source
  • An image unpacking source implementation
  • Updating the CatalogSource controller to use the unpacking interface instead of the currently hardcoded unpacking process
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant