Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking change: remove variable sources and make Deppy accept a slice of variables instead #153

Closed
m1kola opened this issue Oct 30, 2023 · 0 comments · Fixed by #160
Closed

Breaking change: remove variable sources and make Deppy accept a slice of variables instead #153

m1kola opened this issue Oct 30, 2023 · 0 comments · Fixed by #160
Labels
kind/design Categorizes issue or PR as related to design.
Milestone
v0.2.0

Comments

@m1kola
Copy link
Member

m1kola commented Oct 30, 2023

We recently removed entity soruces API. I'm wondering whether we should get rid of concept of variable sources as well and make Deppy accept a slice of variables.
@m1kola m1kola added the kind/design Categorizes issue or PR as related to design. label Oct 30, 2023
@m1kola m1kola mentioned this issue Oct 30, 2023
Closed
4 tasks
@m1kola m1kola added this to the v0.2.0 milestone Nov 15, 2023
@m1kola m1kola mentioned this issue Nov 17, 2023
Merged
@m1kola m1kola changed the title Breaking change: remove concept of variable sources Breaking change: remove variable sources and make Deppy accept a slice of variables instead Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/design Categorizes issue or PR as related to design.
Projects
Deppy
Status: Done
Milestone
v0.2.0
Development

Successfully merging a pull request may close this issue.

⚠️ Remove variable sources and make Deppy accept a slice of variables instead m1kola/deppy
1 participant
@m1kola