Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking change: remove DeppySolver wrapper and export internal solver #161

Closed
m1kola opened this issue Nov 16, 2023 · 0 comments · Fixed by #165
Closed

Breaking change: remove DeppySolver wrapper and export internal solver #161

m1kola opened this issue Nov 16, 2023 · 0 comments · Fixed by #165
Labels
kind/design Categorizes issue or PR as related to design.
Milestone

Comments

@m1kola
Copy link
Member

m1kola commented Nov 16, 2023

When we merge #160 (issue #154) which removes variable sources the DeppySolver becomes not very useful: just a thin wrapper around the solver from the internal package.

I think we can get rid of DeppySolver as well as Solution struct.

I think this should become something like below and get exported:

// Solve takes a slice containing all Variables and returns a slice
// containing only those Variables that were selected for
// installation. If no solution is possible an error is returned.
func (s *solver) Solve(vars []deppy.Variable) ([]deppy.Variable, error) {
	// ...
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/design Categorizes issue or PR as related to design.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant