Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EntitySource API Question #94

Closed
joelanford opened this issue Apr 20, 2023 · 3 comments
Closed

EntitySource API Question #94

joelanford opened this issue Apr 20, 2023 · 3 comments
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@joelanford
Copy link
Member

joelanford commented Apr 20, 2023

I was tinkering with building an EntitySource implementation, and as I was trying to build out the Filter, GroupBy, and Iterate functions, and I realized I always needed to List into memory and then iterate to support these other functions because the backend in my case had no iterator/cursor sort of API.

I wonder if we should relax the base EntitySource API to be just Get and List, and then have an additive interface that callers can type check, to see if the more performant methods could be delegated to the entity source.

  1. If so, call the entity source's methods
  2. If not, List(), and then do the filtering, grouping, iterating at the call site.
@github-actions
Copy link

This issue has become stale because it has been open 60 days with no activity. The maintainers of this repo will remove this label during issue triage or it will be removed automatically after an update. Adding the lifecycle/frozen label will cause this issue to ignore lifecycle events.

@github-actions github-actions bot added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jun 20, 2023
@github-actions
Copy link

This issue has become stale because it has been open 60 days with no activity. The maintainers of this repo will remove this label during issue triage or it will be removed automatically after an update. Adding the lifecycle/frozen label will cause this issue to ignore lifecycle events.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 20, 2023
@joelanford
Copy link
Member Author

This is no longer irrelevant. EntitySource was removed in #108.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

1 participant