Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crd-version and webhook-version flags should be removed #185

Closed
camilamacedo86 opened this issue Aug 3, 2022 · 3 comments · Fixed by #193
Closed

crd-version and webhook-version flags should be removed #185

camilamacedo86 opened this issue Aug 3, 2022 · 3 comments · Fixed by #193
Assignees
@laxmikantbpandhare
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@camilamacedo86
Copy link
Contributor

This flags are deprecated and are only useful for those that want to create CRD and Webhooks using v1beta1 which is longer served since k8s 1.22. This options does not work with the dependencies of controller-runtime and controller-tools used in this project
@camilamacedo86 camilamacedo86 added the kind/bug Categorizes issue or PR as related to a bug. label Aug 3, 2022
@laxmikantbpandhare
Copy link
Member

I will take a look into it.

@laxmikantbpandhare laxmikantbpandhare self-assigned this Aug 9, 2022
This was referenced Aug 10, 2022
Closed
Merged
@laxmikantbpandhare
Copy link
Member

As of now, I added a deprecation warning. Anything else is expected of this issue?

@camilamacedo86
Copy link
Contributor Author

camilamacedo86 commented Aug 10, 2022 •
edited
Loading

This plugin is alpha therefore we can remove things.
Another point is that to use v1beta1 CRD/Webhook would be required to downgrade the dependencies which we do not do here. So, this option does not seems to work well either. Because of this, I thought that the best approach would to be remove them.

@varshaprasad96 wdyt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@laxmikantbpandhare laxmikantbpandhare

Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

added warning message for deprecated flag laxmikantbpandhare/helm-operator-plugins
2 participants
@camilamacedo86 @laxmikantbpandhare