Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reconciler: use server-side dry-run to generate candidate upgrade manifest #344

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

joelanford
Copy link
Member

Closes #209

…ifest

Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.38%. Comparing base (08ab7fb) to head (7eaef52).
Report is 20 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #344       +/-   ##
===========================================
- Coverage   85.06%   48.38%   -36.68%     
===========================================
  Files          19       62       +43     
  Lines        1346     2916     +1570     
===========================================
+ Hits         1145     1411      +266     
- Misses        125     1423     +1298     
- Partials       76       82        +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

spec.Manifest != release.Manifest when helm "lookup" func used in template causing repeat reconcilliation
3 participants