Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to shows the diff between previous manifest and the updated one (action.upgrade) #44

Closed
camilamacedo86 opened this issue Jun 24, 2020 · 2 comments
Closed

Unable to shows the diff between previous manifest and the updated one (action.upgrade) #44

camilamacedo86 opened this issue Jun 24, 2020 · 2 comments
Assignees
@jmrodri

Comments

@camilamacedo86
Copy link
Contributor

See: https://github.com/joelanford/helm-operator/pull/43#pullrequestreview-436841426
@varshaprasad96
Copy link
Member

@camilamacedo86 is this related to logging the diff between the updated manifests. Can you please add more info to this?

@varshaprasad96 varshaprasad96 mentioned this issue Dec 14, 2021
Open
10 tasks
@jmrodri
Copy link
Member

jmrodri commented Dec 14, 2021

During the community meeting it was decided that we do not want to show the diff under normal circumstances. In the past they were at info level. Today we have them at a debug level, the community was fine with leaving it at debug level so that it could be enabled if needed.

@jmrodri jmrodri closed this as completed Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmrodri jmrodri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jmrodri @camilamacedo86 @varshaprasad96