Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflicting slf4j-api version #90

Closed
honnix opened this issue Apr 3, 2023 · 2 comments · Fixed by #91
Closed

Conflicting slf4j-api version #90

honnix opened this issue Apr 3, 2023 · 2 comments · Fixed by #91

Comments

@honnix
Copy link
Contributor

honnix commented Apr 3, 2023

It seems this repo has moved to slf4j-api 2.x, while https://github.com/java-operator-sdk/java-operator-sdk is still on 1.x. This makes code base using both repos (Maven artifacts) non-straight-forward, as 1.x and 2.x are not compatible. I ended up with having:

    <dependency>
      <groupId>io.javaoperatorsdk</groupId>
      <artifactId>kubernetes-webhooks-framework-core</artifactId>
      <exclusions>
        <exclusion>
          <groupId>org.slf4j</groupId>
          <artifactId>slf4j-api</artifactId>
        </exclusion>
      </exclusions>
    </dependency>

Would you consider making this repo stay on 1.x, which I think is still a lot more popular according to maven central? @csviri

@honnix
Copy link
Contributor Author

honnix commented Apr 3, 2023

Note that this was bumped in a dependabot PR: #89, which might not be intentionally. As a matter of fact, I don't think the combination of slf4j 2.x and log4j-slf4j-impl works, see https://logging.apache.org/log4j/2.x/log4j-slf4j-impl.html

@csviri
Copy link
Contributor

csviri commented Apr 4, 2023

Hi @honnix , I started to work on the fix and use log4j-slf4j2-impl what should be there, just it makes issues with annotation processing. But anyways I agree with you, to stay with 1.x for the slf4j api and be also consistent with operators.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants