From 6bc072fa5a44f2884c753b4809c0bb16aceb1f6c Mon Sep 17 00:00:00 2001 From: Varsha Prasad Narsing Date: Tue, 11 Jun 2024 08:07:00 -0700 Subject: [PATCH] Fix error message for unknown unpack state Signed-off-by: Varsha Prasad Narsing --- internal/controllers/clusterextension_controller.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/internal/controllers/clusterextension_controller.go b/internal/controllers/clusterextension_controller.go index e298fc66..cb0653b1 100644 --- a/internal/controllers/clusterextension_controller.go +++ b/internal/controllers/clusterextension_controller.go @@ -263,8 +263,9 @@ func (r *ClusterExtensionReconciler) reconcile(ctx context.Context, ext *ocv1alp } setStatusUnpacked(ext, fmt.Sprintf("unpack successful: %v", unpackResult.Message)) default: - setStatusUnpackFailed(ext, fmt.Sprintf("unpack successful: %v", unpackResult.Message)) - return ctrl.Result{}, fmt.Errorf("unexpected unpack status: %v", err) + setStatusUnpackFailed(ext, "unexpected unpack status") + // We previously exit with a failed status if error is not nil. + return ctrl.Result{}, fmt.Errorf("unexpected unpack status: %v", unpackResult.Message) } bundleFS, err := r.Storage.Load(ctx, ext)