Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconciler does not correctly handle UNSAT resolutions #330

Closed
joelanford opened this issue Aug 11, 2023 · 1 comment · Fixed by #352
Closed

Reconciler does not correctly handle UNSAT resolutions #330

joelanford opened this issue Aug 11, 2023 · 1 comment · Fixed by #352
Labels
kind/bug Categorizes issue or PR as related to a bug.
Milestone

Comments

@joelanford
Copy link
Member

joelanford commented Aug 11, 2023

Related to operator-framework/deppy#139 and possibly #329

In Reconcile we:

  1. Check to see if Solve returned an error.
    • This currently can happen if a variable source returns an error when getting variables.
    • Notably, solve does NOT return an error for UNSAT. This error means "was not able to get variables or setup the solver"
  2. Look for the matching variable in the solution

We skip the step of checking if the solution was SAT or UNSAT. UNSAT currently manifests as an error looking up the bundle entity from the solution. This "works", but it means users don't see the UNSAT reason that comes from solution.Error()

We should check solution.Error(), and handle it accordingly.

@joelanford joelanford added this to the v0.4.0 milestone Aug 15, 2023
@joelanford
Copy link
Member Author

This problem is pretty much solved by operator-framework/deppy#140, which is not yet in a release. We should ask deppy maintainers to create a release with this fix and then our op-con update will be pretty straightforward.

@joelanford joelanford added the kind/bug Categorizes issue or PR as related to a bug. label Aug 16, 2023
@awgreene awgreene modified the milestones: v0.4.0, v0.5.0 Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants