Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make catalogd's CatalogMetadata APIs available for operator-controller #334

Closed
joelanford opened this issue Aug 15, 2023 · 2 comments
Closed
Assignees
Milestone

Comments

@joelanford
Copy link
Member

While we wait for operator-framework/catalogd#139, I propose that we start using catalogd's CatalogMetadata API instead of its BundleMetadata and Package APIs.

The CatalogMetadata API contains (almost) all of the FBC that the eventual catalogd file server will, so it is a good step forward, and is something that folks implementing some of the existing RFCs can use right now. This will ease an eventual migration to the catalogd file server.

Catalogd main branch currently has CatalogMetadata APIs enabled. We just need to ask catalogd maintainers to cut a release and bump our dependency on it.

@joelanford joelanford added this to the v0.4.0 milestone Aug 15, 2023
@joelanford joelanford changed the title Move variable sources and/or entity sources over to CatalogMetadata Make catalogd's CatalogMetadata APIs available for operator-controller Aug 15, 2023
@joelanford joelanford mentioned this issue Aug 15, 2023
4 tasks
@joelanford joelanford self-assigned this Aug 15, 2023
@m1kola
Copy link
Member

m1kola commented Aug 21, 2023

Sounds good! I think this also solves this todo:

// TODO: Reduce code duplication: share a function with catalogdEntitySource (see getEntities)
// We don't want to maintain two functions performing conversion into input.EntityList.
// For this we need some common format. So we need a package which will be able
// to convert from declfcg structs into CRD structs directly or via model.Model.
// One option would be to make this piece of code from catalogd reusable and exportable:
// https://github.com/operator-framework/catalogd/blob/9fe45a628de2e74d9cd73c3650fa2582aaac5213/pkg/controllers/core/catalog_controller.go#L200-L360

But instead of converting declcfg into CRDs as initially suggested in TODO we operate on declcfg everywhere.

@m1kola
Copy link
Member

m1kola commented Aug 21, 2023

Sorry, I misunderstood it at first. This ticket only aims at making CatalogMetadata available to operator-controller which was already done in #339 / #336.

To solve the todo mentioned above I created #342.

I think we can close this issue.

@m1kola m1kola closed this as completed Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants