Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a CI check to make sure that pull requests are not missing make generate #348

Open
m1kola opened this issue Aug 22, 2023 · 2 comments
Open
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.

Comments

@m1kola
Copy link
Member

m1kola commented Aug 22, 2023

We need a check for PRs to make sure that we generate all the generated code and yamls as part of a PR.

@joelanford
Copy link
Member

Just need to add manifests to this target's dependencies?

verify: tidy fmt generate ## Verify the current code generation.

CI already runs make verify as part of the sanity workflow.

@m1kola
Copy link
Member Author

m1kola commented Aug 22, 2023

@joelanford you are right we already have verify which runs git diff --exit-code and we can add manifests as a dependency.

However git diff --exit-code will only produce non-zero exit code if there is a diff in tracked files and it will miss cases when working copy is dirty due to new untracked files as result of code generation.

I think we need something like [[ -z "$(git status -s)" ]] instead.

@m1kola m1kola added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.
Projects
None yet
Development

No branches or pull requests

2 participants