Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add semver upgrade edge generation support #398

Closed
m1kola opened this issue Sep 5, 2023 · 2 comments · Fixed by #444
Closed

Add semver upgrade edge generation support #398

m1kola opened this issue Sep 5, 2023 · 2 comments · Fixed by #444
Assignees
Milestone

Comments

@m1kola
Copy link
Member

m1kola commented Sep 5, 2023

Please read RFC for better formatting and full scope. The excerpt below is just to indicate the scope covered by this specific issue.

Need to implement semver upgrade edge generation function as discussed in the RFC.

Semver

Semver based implementation is expected to:

  • Satisfy the interface discussed above
  • Return a list of successor bundles based on semver. The list will not include bundle versions outside the major version of the installed bundle. (In semver a new major version is intended to indicate breaking changes, and we don’t want to default to that behavior. Future iterations may include knobs to extend this behavior.)
  • This mode will not allow downgrading.

As part of this issue we also need to make sure that ForceSemverUpgradeConstraints feature gate is respected:

The solver needs to be able to switch between upgrade constraint semantics based on rules defined above (see Fig 1).

@grokspawn
Copy link
Contributor

blocked by #347

@m1kola
Copy link
Member Author

m1kola commented Sep 7, 2023

Also I think #397 should happen first as it introduces the interface into codebase.

@joelanford joelanford added this to the v0.6.0 milestone Sep 14, 2023
@dtfranz dtfranz modified the milestones: v0.6.0, v0.7.0 Oct 3, 2023
@m1kola m1kola self-assigned this Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants