Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extensible values field to Extension spec #612

Open
Tracked by #593
oceanc80 opened this issue Feb 1, 2024 · 1 comment
Open
Tracked by #593

Add extensible values field to Extension spec #612

oceanc80 opened this issue Feb 1, 2024 · 1 comment

Comments

@oceanc80
Copy link

oceanc80 commented Feb 1, 2024

In scope:

  • Registry+v1 bundles only
  • watchNamespaces
  • Stretch: subscription.spec.config
@joelanford
Copy link
Member

I think we should hold off on making watchNamespaces a first-class field in the Extension API.

Instead, I think we should implement a generic values-style field in the Extension API (similar to Carvel's PackageInstall.spec.values), which we would pass down into the App CR.

For registry+v1 bundles, we will control the YTT template, so we can implement that template to handle a watchNamespaces value if it is defined.

cc @varshaprasad96

@joelanford joelanford changed the title Add watchNamespaces to Extension spec Add extensible values field to Extension spec Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants