Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a check for removing an existing field #664

Closed
Tracked by #657
everettraven opened this issue Feb 27, 2024 · 2 comments
Closed
Tracked by #657

Add a check for removing an existing field #664

everettraven opened this issue Feb 27, 2024 · 2 comments
Assignees
Labels
epic/crd-upgrade-safety Marks an issue as part of the CRD Upgrade Safety epic

Comments

@everettraven
Copy link
Contributor

everettraven commented Feb 27, 2024

This builds on top of #661 and focuses on adding a check to ensure that performing an update operation to a CustomResourceDefinition does not result in an existing field being removed.

If the proposal for adding this functionality to carvel-dev/kapp has been accepted prior to starting this work, all changes should be made against carvel-dev/kapp, otherwise the changes should be made against https://github.com/everettraven/kapp/tree/feature/crd-upgrade-safety-preflight

@everettraven everettraven added the epic/crd-upgrade-safety Marks an issue as part of the CRD Upgrade Safety epic label Mar 13, 2024
@everettraven
Copy link
Contributor Author

The proposal has been merged and a new issue has been created in carvel-dev/kapp to track this change. In turn, this is now a placeholder/tracker issue for carvel-dev/kapp#912

@rashmigottipati
Copy link
Member

Closing as completed with the PR merged into carvel-dev/kapp: carvel-dev/kapp#922

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic/crd-upgrade-safety Marks an issue as part of the CRD Upgrade Safety epic
Projects
Status: Done
Development

No branches or pull requests

2 participants