Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kapp-controller to allow the use of the --preflight flag when using kapp as the deployment method #688

Closed
everettraven opened this issue Mar 11, 2024 · 3 comments
Labels
epic/crd-upgrade-safety Marks an issue as part of the CRD Upgrade Safety epic

Comments

@everettraven
Copy link
Contributor

everettraven commented Mar 11, 2024

Once a version of carvel-dev/kapp with support for preflight checks has been released and carvel-dev/kapp-controller has been updated to use that version, kapp-controller needs to be updated to support configuring the preflight checks provided to kapp via the App CR.

For some additional context as to how kapp-controller configures the flags that can be passed to kapp via the App CR, see carvel-dev/kapp-controller#1381 (comment)

@joelanford
Copy link
Member

What does this entail? Is it just a bump of the kapp-controller version we depend on? Do we know which version of kapp-controller we'll need yet?

@everettraven
Copy link
Contributor Author

What does this entail? Is it just a bump of the kapp-controller version we depend on? Do we know which version of kapp-controller we'll need yet?

Sorry, was updating the parent epic issue with some more stuff that we will need to do on the carvel side of things. I made the issue based on a new check box I added so it defaulted to no description. I'm planning to spend some time today to go through all the issues in the parent epic and making sure that all the descriptions are up to date.

@everettraven everettraven added the epic/crd-upgrade-safety Marks an issue as part of the CRD Upgrade Safety epic label Mar 13, 2024
@everettraven
Copy link
Contributor Author

Closing this issue as we are no longer planning to build on top of the carvel tool suite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic/crd-upgrade-safety Marks an issue as part of the CRD Upgrade Safety epic
Projects
Archived in project
Development

No branches or pull requests

2 participants