Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[epic] Support interaction similar to OLMv0's OperatorConditions upgrade blocking #739

Open
joelanford opened this issue Apr 4, 2024 · 4 comments
Assignees
Labels
epic v1.x Issues related to OLMv1 features that come after 1.0

Comments

@joelanford
Copy link
Member

No description provided.

@joelanford joelanford self-assigned this Apr 4, 2024
@joelanford joelanford added epic priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. v1.0 Issues related to the initial stable release of OLMv1 and removed priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Apr 4, 2024
@joelanford joelanford removed their assignment Apr 4, 2024
@OchiengEd
Copy link

/assign

@OchiengEd
Copy link

  • Implement the OperatorConditions controller
  • Pull and apply the OperatorConditions CRD from operator-framework/api repo
  • Write tests for OperatorConditions controller
  • Implement logging for OperatorConditions controller

@joelanford
Copy link
Member Author

Note from @dinhxuanvu:

  • OLMv0 has two different versions of this CRD. We need to make sure we understand the history of this API when we implement it for OLMv1.
  • Follow the v2 convention for single writer to either spec or status.

@dinhxuanvu
Copy link
Member

Just a note now that I remember "something".

We didn't do any CR conversion between v1 and v2 because we didn't use kube-storage-version-migrator or anything like that to do the conversion automatically. Even if the CR is stored under v1 initially in etcd, when the CR is served, it will have v2 tag/version as I apiserver automatically converts from v1 to v2 if the client is querying v2 endpoint. v2 is the storage version so upon writing back, it should be written as v2 in etcd moving forward. Both versions are serving versions to avoid breaking the operators' operation if they are using v1. v2 is adding a new field if IRCC so the conversion from v1 to v2 shouldn't lose any data.

@joelanford joelanford added v1.x Issues related to OLMv1 features that come after 1.0 and removed v1.0 Issues related to the initial stable release of OLMv1 labels Jun 10, 2024
@joelanford joelanford changed the title [epic] Support OLMv0 OperatorConditions expectations of registry+v1 bundles [epic] Support interaction similar to OLMv0's OperatorConditions upgrade blocking Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic v1.x Issues related to OLMv1 features that come after 1.0
Projects
Status: No status
Development

No branches or pull requests

3 participants