Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[epic] Support orphan deletion policy #775

Open
joelanford opened this issue Apr 22, 2024 · 5 comments
Open

[epic] Support orphan deletion policy #775

joelanford opened this issue Apr 22, 2024 · 5 comments
Labels
epic v1.x Issues related to OLMv1 features that come after 1.0

Comments

@joelanford
Copy link
Member

No description provided.

@joelanford joelanford added epic v1.x Issues related to OLMv1 features that come after 1.0 labels Apr 22, 2024
@varshaprasad96
Copy link
Member

A quick clarification and probably an implementation detail too - Once the clusterextension/extension is deleted and the respective objects are left behind, we need to remove watches on them so that we don't end up spending reconciles for events triggered from those objects, though modifying orphaned objects independently could be rare scenario and is discouraged. A very simple implementation I can think of is predicate based filtering based on a label.

@joelanford
Copy link
Member Author

Once the clusterextension/extension is deleted and the respective objects are left behind, we need to remove watches on them so that we don't end up spending reconciles for events triggered from those objects

Agreed!

A very simple implementation I can think of is predicate based filtering based on a label.

Yes, and I think rukpak already does that. It uses a dependentSelector to set up the watches. When we orphan those objects, we just need to make sure to remove the labels that are selected by that predicate (or the equivalent predicate we eventually add to operator-controller).

@varshaprasad96
Copy link
Member

Just adding links to some resources, so that we don't lose track and can revisit later:
Pre/post delete hooks: https://helm.sh/docs/topics/charts_hooks/#the-available-hooks
Orphan release resources: https://helm.sh/docs/howto/charts_tips_and_tricks/#tell-helm-not-to-uninstall-a-resource

@yashoza19
Copy link
Contributor

/assign

@yashoza19
Copy link
Contributor

/unassign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic v1.x Issues related to OLMv1 features that come after 1.0
Projects
Status: No status
Development

No branches or pull requests

3 participants