Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Bundle image source should use ext.Spec.InstallNamespace, not systemNamespace #944

Open
Tracked by #950
joelanford opened this issue Jun 15, 2024 · 1 comment
Open
Tracked by #950

Bug: Bundle image source should use ext.Spec.InstallNamespace, not systemNamespace #944

joelanford opened this issue Jun 15, 2024 · 1 comment
Assignees
@LalatenduMohanty
Labels
kind/bug Categorizes issue or PR as related to a bug. v1.0 Issues related to the initial stable release of OLMv1

Comments

@joelanford
Copy link
Member

See:

operator-controller/cmd/manager/main.go

Line 180 in f301f55

unpacker, err := source.NewDefaultUnpacker(mgr, systemNamespace, filepath.Join(cachePath, "unpack"), (*x509.CertPool)(nil))

This likely means a slight refactoring of the ImageRegistry implementation.

Related: it probably makes sense to stop using the composite unpacker and instead just use ImageRegistry directly.
@joelanford joelanford added kind/bug Categorizes issue or PR as related to a bug. v1.0 Issues related to the initial stable release of OLMv1 labels Jun 15, 2024
@joelanford joelanford mentioned this issue Jun 17, 2024
Open
18 tasks
@LalatenduMohanty
Copy link

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LalatenduMohanty LalatenduMohanty

Labels
kind/bug Categorizes issue or PR as related to a bug. v1.0 Issues related to the initial stable release of OLMv1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joelanford @LalatenduMohanty