Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wire up installation of content using a provided ServiceAccount #973

Open
Tracked by #737
everettraven opened this issue Jun 25, 2024 · 0 comments
Open
Tracked by #737
Assignees

Comments

@everettraven
Copy link
Contributor

everettraven commented Jun 25, 2024

Following #971 and #972, we need to wire up the logic such that a ServiceAccount referenced in a ClusterExtension is used to install/upgrade/uninstall content via the Helm client.

While exact implementation may vary, here are some things to consider during implementation:

Acceptance Criteria:

  • The client.NewActionConfigGetter setup in
    cfgGetter, err := helmclient.NewActionConfigGetter(mgr.GetConfig(), mgr.GetRESTMapper(),
    helmclient.StorageNamespaceMapper(installNamespaceMapper),
    helmclient.ClientNamespaceMapper(installNamespaceMapper),
    )
    if err != nil {
    setupLog.Error(err, "unable to config for creating helm client")
    os.Exit(1)
    }
    is updated to use a client.RestConfigMapper that creates a rest.Config configured with a token from the ServiceAccount referenced in a ClusterExtension
  • Updates to the existing unit + e2e tests as necessary for them to continue functioning as expected. It is anticipated that some work will need to be done to configure a ServiceAccount with appropriate permissions to be used during e2e tests.
  • Permissions on the operator-controller ServiceAccount should be updated to no longer require write permissions on content to be installed (and clean up any other permissions that are no longer necessary)
  • Any changes to the previously implemented interfaces to facilitate the wiring of components successfully are made
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

2 participants