Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade status improvements given Helm as the underlying installer #985

Open
bentito opened this issue Jun 27, 2024 · 0 comments
Open

Upgrade status improvements given Helm as the underlying installer #985

bentito opened this issue Jun 27, 2024 · 0 comments

Comments

@bentito
Copy link
Contributor

bentito commented Jun 27, 2024

In the clusterextension_controller.go we ask the underlying Helm client to upgrade a bundle. This may fail. Unfortunately, there are no error types for Helm upgrade errors.

Error messages could be parsed and branched on, they range from: useful for users of the API to ambiguous. Here is a sampling with links to the issues they are drawn from:

failed to create patch: map: map[] does not contain declared merge key: name
https://github.com/helm/helm/issues/9259

has no deployed releases
https://github.com/helm/helm/issues/7160

context deadline exceeded
https://github.com/helm/helm/issues/9094

UPGRADE FAILED: failed to create patch: map: map[] does not contain declared merge key: name
https://github.com/helm/helm/issues/9259

create: failed to create: context deadline exceeded
https://github.com/helm/helm/issues/9094

Error: UPGRADE FAILED: failed to create patch: map: map[] does not contain declared merge key: name
https://github.com/helm/helm/issues/9259

Looks like there are no changes for Deployment
https://github.com/helm/helm/issues/5792

context deadline exceeded
https://github.com/helm/helm/issues/9094

UPGRADE FAILED: failed to create patch: map: map[] does not contain declared merge key: name
https://github.com/helm/helm/issues/9259

no deployed releases
https://github.com/helm/helm/issues/7160

failed to create patch: map: map[] does not contain declared merge key: name
https://github.com/helm/helm/issues/9259

This issue is to track the need to report properly when actionable upgrade errors are found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant