Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After it be installed the URL to connect/use it should be informed to the user #785

Closed
camilamacedo86 opened this issue Mar 25, 2019 · 4 comments

Comments

@camilamacedo86
Copy link
Contributor

WHAT

After it is installed the URL to connect/use it should be informed to the user

WHY

Make clear for the user what URL them should use to access it. In the output appears another URL and make it very confusing.

Example:

As it is done for Minishift.

The OLM is accessible via web console at:
    https://localhost:9000/
@ecordell
Copy link
Member

ecordell commented May 9, 2019

Are you referring to the ./scripts/run_console_local.sh script? I believe it tells you where the UI is accessible?

@camilamacedo86
Copy link
Contributor Author

camilamacedo86 commented May 12, 2019

HI @ecordell,

Following the details.

Where should be this change?

It is in the $ ./scripts/run_console_local.sh.

Is not this info already shown?

No, it does no show the info/msg as was requested here which is a small improvement just to make better the usability. It is very common that the user will following the readme but will not see that it is accessible by https://localhost:9000/, then shows the info at the end of the script appears to be a really small effort and will be really helpful for them.

Screenshot 2019-05-13 at 08 30 23

NOTE

This script is broken in the master branch currently.

$ ./scripts/run_console_local.sh
./scripts/run_console_local.sh: line 7: syntax error in conditional expression: unexpected token `('
./scripts/run_console_local.sh: line 7: syntax error near `*@(M'
./scripts/run_console_local.sh: line 7: `if [[ $OSTYPE == darwin* ]] || [[ "$(< /proc/version)" == *@(Microsoft|WSL)* ]]; then'

Also, wdyt about we use makefile and create make commands to install, start, etc..?

IMPORTANT: I am working on doing a PR for it.

@camilamacedo86
Copy link
Contributor Author

Following the PR made:
#858

@camilamacedo86
Copy link
Contributor Author

Closing since the PR is merged 👍 tks for the review and support :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants