Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The ability to pull CatalogSource images from private docker registries #982

Closed
alikor opened this issue Aug 13, 2019 · 3 comments
Closed

Comments

@alikor
Copy link

alikor commented Aug 13, 2019

It should be possible to pass in an optional imagePullSecrets field when creating CatalogSource of sourceType: grpc to be able to pull images that are hosted on private docker registries

@alikor alikor changed the title The ability to pull CatalogSource from private docker registries The ability to pull CatalogSource images from private docker registries Aug 13, 2019
@dmesser
Copy link
Contributor

dmesser commented Aug 14, 2019

Did you try putting a pull secret in the namespace of your CatalogSource object?

@alikor
Copy link
Author

alikor commented Aug 14, 2019

I am not sure what you are suggesting?

I had a quick look at the code looks like imagepullsecrets are attached the the Pod the container is running in would need to change the CRD spec structure and a factory method

And obviously some operator tests

@ecordell
Copy link
Member

This can be done "manually" by creating a deployment pointing to your image, and creating a catalogsource that uses the spec.address field to point to the running pod in the deployment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants