Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port Website to Docsy Go module #5496

Open
asmacdo opened this issue Jan 13, 2022 · 7 comments
Open

Port Website to Docsy Go module #5496

asmacdo opened this issue Jan 13, 2022 · 7 comments
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/documentation Categorizes issue or PR as related to documentation. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. needs discussion priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Milestone

Comments

@asmacdo
Copy link
Member

asmacdo commented Jan 13, 2022

Operator Framework sites are built with Hugo and the Docsy theme, which was previously versioned as a git submodule. We had to go pretty far outside of the accepted best practices to get our custom theme, and it has prevented us from migrating to newer versions of docsy.

Docsy is now available as a go module plugin to hugo instead, which should be significantly easier to upgrade.

Original discussion: google/docsy#535

Porting to module docs:

We will likely run into some trouble here, since we did so much beyond-best-practice stuff to override our custom theme. If we do, the best place ask questions here https://github.com/google/docsy/discussions/

@asmacdo asmacdo added the kind/documentation Categorizes issue or PR as related to documentation. label Jan 13, 2022
@asmacdo
Copy link
Member Author

asmacdo commented Jan 13, 2022

The part of this to watch for is whether we can cleanly override the docsy theme. If that part does not go smoothly, this could be a significant amount of front-end work.

@deining
Copy link

deining commented Jan 18, 2022

The author that ported docsy theme to a module here 😄.
I might be able to help you out in the transition of your documenation to dosy hugo module.
Having a look at your website folder, I realized, that it's content is not self-contained yet. I have no idea what revision/commit of the docsy theme you are using. Are you able to add the docsy theme as a submodule, at the revision that your production site uses right now? Once I'm able to clone your site and run it locally, I will try to add the option to convert/use it as module. Your site can still use submodules, I should be able to bring it into a state where you can switch back and forth between module and submodule quite easily.
I was curious and had a first quick glance and I immediately realized that your site/repo has to be reworked on several places to make it compatible with modules. So don't be deceived: while hugo modules are great, they are by no means a magic wand that will upgrade your site to the latest version without manual rework.

@varshaprasad96 varshaprasad96 added needs discussion priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Jan 24, 2022
@varshaprasad96 varshaprasad96 added this to the Backlog milestone Jan 24, 2022
@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 25, 2022
@asmacdo
Copy link
Member Author

asmacdo commented Apr 26, 2022

/lifecycle frozen

@openshift-ci openshift-ci bot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 26, 2022
@varshaprasad96 varshaprasad96 added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels May 18, 2022
@varshaprasad96 varshaprasad96 removed lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Jun 8, 2022
@asmacdo asmacdo added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Jun 29, 2022
@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 28, 2022
@jberkhahn
Copy link
Contributor

/lifecycle-frozen

@jberkhahn jberkhahn removed the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Oct 12, 2022
@jberkhahn
Copy link
Contributor

/lifecycle frozen

@openshift-ci openshift-ci bot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/documentation Categorizes issue or PR as related to documentation. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. needs discussion priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Development

No branches or pull requests

5 participants