Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to k8s 1.24 #5871

Closed
camilamacedo86 opened this issue Jun 13, 2022 · 1 comment
Closed

Add support to k8s 1.24 #5871

camilamacedo86 opened this issue Jun 13, 2022 · 1 comment
Labels
release-blocker This issue blocks the parent release milestone
Milestone

Comments

@camilamacedo86
Copy link
Contributor

camilamacedo86 commented Jun 13, 2022

Feature Request

Describe the problem you need a feature to resolve.

To pass on the tests against 1.24 we are creating a token in the tests, see: https://github.com/operator-framework/operator-sdk/blob/master/test/common/sa_secret.go

However, that means if we follow up the quick start against on cluster with 1.24 that will probably not work because it is missing the token. So, we need to ensure that the projects scaffold with SDK properly works on 1.24

Describe the solution you'd like.

The solution might be to scaffold the token alongside the SA.

@camilamacedo86 camilamacedo86 added this to the v1.22.0 milestone Jun 13, 2022
@camilamacedo86 camilamacedo86 added the release-blocker This issue blocks the parent release milestone label Jun 13, 2022
@camilamacedo86
Copy link
Contributor Author

camilamacedo86 commented Jun 14, 2022

To ensure that the token is not required with the default scaffold I pushed a PR against Kubebuilder (kubernetes-sigs/kubebuilder#2724) where we commented the curl call to validate the metrics and we were not using the token. the tests against 1.24 passed so it shows safe we say that we do not need to scaffold any token for the Sa and is all fine.

See: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_kubebuilder/2724/pull-kubebuilder-e2e-k8s-1-24-1/1536642364532068352

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-blocker This issue blocks the parent release milestone
Projects
None yet
Development

No branches or pull requests

1 participant