Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Designing Lean Operators #6581

Closed
fgiloux opened this issue Sep 25, 2023 · 8 comments
Closed

Designing Lean Operators #6581

fgiloux opened this issue Sep 25, 2023 · 8 comments
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Milestone
Backlog

Comments

@fgiloux
Copy link
Contributor

fgiloux commented Sep 25, 2023

The page needs to be updated.

There was a breaking change in controller-runtime so that BuilderWithOptions has been removed.
The use case should now be covered by cache.Options, the ByObject field being now a map.

Controller-runtime design document: https://github.com/kubernetes-sigs/controller-runtime/blob/main/designs/cache_options.md
@acornett21
Copy link
Contributor

This is the page in question:
https://master.sdk.operatorframework.io/docs/best-practices/designing-lean-operators/

@fgiloux
Copy link
Contributor Author

fgiloux commented Sep 25, 2023

Changes introduced in v0.15.0
SDK currently using v0.14.1.
Thanks for linking the bump issue.

@varshaprasad96 varshaprasad96 added this to the Backlog milestone Oct 2, 2023
@varshaprasad96 varshaprasad96 added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Oct 2, 2023
@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 1, 2024
@fgiloux
Copy link
Contributor Author

fgiloux commented Jan 2, 2024

/remove-lifecycle stale

@openshift-ci openshift-ci bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 2, 2024
@fgiloux
Copy link
Contributor Author

fgiloux commented Jan 2, 2024

More relevant than even since #6613 has merged

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 1, 2024
@fgiloux
Copy link
Contributor Author

fgiloux commented Apr 1, 2024

/remove-lifecycle stale

@openshift-ci openshift-ci bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 1, 2024
@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 1, 2024
@fgiloux fgiloux closed this as completed Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
4 participants
@openshift-bot @fgiloux @varshaprasad96 @acornett21