Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate bundle ignore RelatedImages from config/manifests/bases #6590

Open
rollandf opened this issue Oct 3, 2023 · 10 comments
Open

Generate bundle ignore RelatedImages from config/manifests/bases #6590

rollandf opened this issue Oct 3, 2023 · 10 comments
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. language/go Issue is related to a Go operator project lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Milestone

Comments

@rollandf
Copy link

rollandf commented Oct 3, 2023

Bug Report

What did you do?

generate bundle using kustomize with RelatedImages in config/manifests/bases/my.clusterserviceversion.yaml

What did you expect to see?

The generated CSV should include the provided RelatedImages

What did you see instead? Under which circumstances?

The generated CSV does not include the provided RelatedImages
used to worked until v1.19.0

Environment

Operator type:

/language go

Kubernetes cluster type:
vanilla

$ operator-sdk version
v1.19.1
(worked with v1.19.0)

$ go version (if language is Go)

$ kubectl version

Possible Solution

Merge the provided RelatedImages with the auto detected.
Suspected PR that introduced the change: #5656

Additional context

@openshift-ci openshift-ci bot added the language/go Issue is related to a Go operator project label Oct 3, 2023
@acornett21
Copy link
Contributor

Hi @rollandf, does this issues exist with a recent version of operator-sdk? v1.19.1 is well over a year and a half old, just trying to gauge if this issue still exists. Thanks.

@rollandf
Copy link
Author

rollandf commented Oct 9, 2023

@acornett21
Copy link
Contributor

Thanks for confirming...As a workaround, operator-sdk can build the related images section in the csv with the following:

USE_IMAGE_DIGESTS=true make bundle

This pins the images to the proper sha value and also builds the related images section.

@everettraven everettraven added the kind/bug Categorizes issue or PR as related to a bug. label Oct 9, 2023
@everettraven everettraven added this to the Backlog milestone Oct 9, 2023
@everettraven everettraven added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Oct 9, 2023
@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 8, 2024
@rollandf
Copy link
Author

/remove-lifecycle stale

@openshift-ci openshift-ci bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 17, 2024
@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 17, 2024
@rollandf
Copy link
Author

/remove-lifecycle stale

@openshift-ci openshift-ci bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 17, 2024
@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 16, 2024
@rollandf
Copy link
Author

/remove-lifecycle stale

@openshift-ci openshift-ci bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 16, 2024
@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. language/go Issue is related to a Go operator project lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

4 participants