New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change `./bin` to `LOCALBIN` #6637

Closed

mateusoliveira43 opened this issue Dec 6, 2023 · 1 comment · Fixed by #6655

Assignees

Labels

good first issue

Milestone

mateusoliveira43 commented Dec 6, 2023

Feature Request

Describe the problem you need a feature to resolve.

Path to some tools binaries is hard coded with ./bin, instead of using LOCALBIN (https://github.com/kubernetes-sigs/kubebuilder/blob/3c9cf656ce4d62a10c8e78a1c0f066de47c983db/pkg/plugins/golang/v3/scaffolds/internal/templates/makefile.go#L185).

Example

operator-sdk/internal/plugins/manifests/v2/init.go

Line 207 in e001847

OPERATOR_SDK ?= ./bin/operator-sdk

Describe the solution you'd like.

It would be also nice if tools binaries variables (OPERATOR_SDK, OPM, OPERATOR_SDK_VERSION and OPM_VERSION, which does not exist) could be grouped in here https://github.com/kubernetes-sigs/kubebuilder/blob/3c9cf656ce4d62a10c8e78a1c0f066de47c983db/pkg/plugins/golang/v3/scaffolds/internal/templates/makefile.go#L189-L196

The text was updated successfully, but these errors were encountered:

theishshah added the good first issue label

theishshah added this to the Backlog milestone

Contributor

lunarwhite commented Jan 8, 2024

/assign
I'd like to help this issue.

openshift-ci bot assigned lunarwhite

lunarwhite mentioned this issue

refactor: change './bin' to 'LOCALBIN' #6655

Merged

2 tasks

everettraven closed this as completed in #6655

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment