Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Attribute Tags to XML output #5241

Merged
merged 2 commits into from
Oct 6, 2021
Merged

Add Attribute Tags to XML output #5241

merged 2 commits into from
Oct 6, 2021

Conversation

theishshah
Copy link
Member

This is a PR to change the XML output to support attribute tags instead of nested attributes in the result. This will allow users of existing test parsing tools to use the scorecard xml results without post run pruning.

change xml types to attribute fields
e13000c 
Signed-off-by: Ish Shah <ishah@redhat.com>
@theishshah
Copy link
Member Author

theishshah commented Sep 24, 2021 •
edited
Loading

operator-sdk scorecard bundle -o xunit

<TestSuites name="scorecard">
  <testsuite name="olm-spec-descriptors" failures="Loaded ClusterServiceVersion: memcached-operator.v0.0.1&#xA;Loaded 1 Custom Resources from alm-examples&#xA;" id="olm-spec-descriptors" url="quay.io/operator-framework/scorecard-test:v1.9.0">
    <testcase name="olm-spec-descriptors">
      <failure type="Failure" message="Loaded ClusterServiceVersion: memcached-operator.v0.0.1&#xA;Loaded 1 Custom Resources from alm-examples&#xA;"></failure>
    </testcase>
  </testsuite>

See above potential output for a failure case

camilamacedo86
camilamacedo86 suggested changes Oct 2, 2021
View reviewed changes
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing changelog
Also, could you please add in the first command an example of its usage after the changes?

add changelog
1813516 
Signed-off-by: Ish Shah <ishah@redhat.com>
jmrodri
jmrodri approved these changes Oct 6, 2021
View reviewed changes
Copy link
Member

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 6, 2021
@theishshah theishshah merged commit 90d1880 into operator-framework:master Oct 6, 2021
@theishshah theishshah deleted the xmlAttr branch October 6, 2021 16:29
@theishshah theishshah restored the xmlAttr branch October 6, 2021 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camilamacedo86 camilamacedo86 camilamacedo86 requested changes

@jmrodri jmrodri jmrodri approved these changes

@asmacdo asmacdo Awaiting requested review from asmacdo

@rashmigottipati rashmigottipati Awaiting requested review from rashmigottipati

Assignees

@jmrodri jmrodri

Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@theishshah @jmrodri @camilamacedo86