Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: scorecard: output the failed CR from basic test #5255

Merged
merged 1 commit into from
Oct 6, 2021

Conversation

jmrodri
Copy link
Member

@jmrodri jmrodri commented Sep 29, 2021

Signed-off-by: jesus m. rodriguez jesusr@redhat.com

Description of the change:
Print out the failed CRD in the Suggestions.

Motivation for the change:
When the basic test fails the error is just "spec is missing" but doesn't tell you where.

Checklist

If the pull request includes user-facing changes, extra documentation is required:

@jmrodri
Copy link
Member Author

jmrodri commented Sep 29, 2021

--------------------------------------------------------------------------------                                       
Image:      quay.io/jesusr/scorecard-test:dev
Entrypoint: [scorecard-test basic-check-spec]                                                                          
Labels:                                                                                                                
        "suite":"basic"
        "test":"basic-check-spec-test"
Results:
        Name: basic-check-spec
        State: fail

        Suggestions:
                spec missing from [gatekeeper]
        Errors:
                error spec does not exist

Signed-off-by: jesus m. rodriguez <jesusr@redhat.com>
@jmrodri
Copy link
Member Author

jmrodri commented Sep 29, 2021

Fixes #5212

Copy link
Member

@asmacdo asmacdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 29, 2021
@asmacdo asmacdo modified the milestones: v1.13.0, v1.14.0 Sep 29, 2021
Copy link
Member

@rashmigottipati rashmigottipati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jmrodri jmrodri merged commit 8f4243f into operator-framework:master Oct 6, 2021
@jmrodri jmrodri deleted the scorecard-error branch January 30, 2022 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants