Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check GOBIN on make install #6629

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Conversation

bentito
Copy link
Contributor

@bentito bentito commented Nov 11, 2023

Description of the change:
Add checking for set GOBIN on make install

Motivation for the change:
With this change we catch situation where GOBIN isn't defined and make install silently fails.

$ unset GOBIN
$ make install
Error: GOBIN is not set
make: *** [Makefile:75: install] Error 1
$ source ~/.bash_profile
$ echo $GOBIN/
/usr/local/go/bin/
$ make install
go install -gcflags "all=-trimpath=/home/user1" -asmflags "all=-trimpath=/home/user1" -ldflags " -X 'github.com/operator-framework/operator-sdk/internal/version.Version=v1.32.0+git' -X 'github.com/operator-framework/operator-sdk/internal/version.GitVersion=v1.32.0-6-g034aef67-dirty' -X 'github.com/operator-framework/operator-sdk/internal/version.GitCommit=034aef6779729a30ac3d716f93a01824ed8dd3c7' -X 'github.com/operator-framework/operator-sdk/internal/version.KubernetesVersion=v1.26.0' -X 'github.com/operator-framework/operator-sdk/internal/version.ImageVersion=v1.32.0' "  ./cmd/{operator-sdk,helm-operator}
$ which operator-sdk
/usr/local/go/bin/operator-sdk

proposed as a fix for #6627

Checklist

If the pull request includes user-facing changes, extra documentation is required:

@grokspawn
Copy link
Contributor

Hey @bentito would you please rebase this PR and signoff the commits?

Signed-off-by: Brett Tofel <btofel@redhat>
Signed-off-by: Brett Tofel <btofel@redhat.com>
@bentito
Copy link
Contributor Author

bentito commented Nov 16, 2023

Hey @bentito would you please rebase this PR and signoff the commits?

okay rebased, signed off, DCO passing now

@grokspawn grokspawn merged commit 0114601 into operator-framework:master Nov 17, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants