Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align cmdline parameter names cases #428

Open
artek-koltun opened this issue Jan 15, 2024 · 0 comments
Open

Align cmdline parameter names cases #428

artek-koltun opened this issue Jan 15, 2024 · 0 comments
Labels
good first issue Good for newcomers

Comments

@artek-koltun
Copy link
Collaborator

artek-koltun commented Jan 15, 2024

For some cmds, parameter names are separated by - char, in others camel case is used.

For example

godpu/cmd/evpn-svi.go

Lines 51 to 53 in 63d1b25

cmd.Flags().StringVar(&logicalBridge, "logicalBridge", "", "Pair of vni and vlan_id must be unique")
cmd.Flags().StringVar(&mac, "mac", "", "GW MAC address, random MAC assigned if not specified")
cmd.Flags().StringSliceVar(&gwIPs, "gw-ips", nil, "List of GW IP addresses")

godpu/cmd/evpn-svi.go

Lines 103 to 104 in 63d1b25

cmd.Flags().BoolVarP(&allowMissing, "allowMissing", "a", false, "Specify the name of the BridgePort")
cmd.Flags().StringVar(&addr, "addr", "localhost:50151", "address of OPI gRPC server")

godpu/cmd/evpn-svi.go

Lines 221 to 222 in 63d1b25

cmd.Flags().StringSliceVar(&updateMask, "update-mask", nil, "update mask")
cmd.Flags().BoolVarP(&allowMissing, "allowMissing", "a", false, "allow the missing")

cmd.Flags().BoolVar(&allowMissing, "allowMissing", false, "cmd succeeds if attempts to delete a resource that is not present")

Code should be aligned in all files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant