Skip to content

Commit

Permalink
feat(ospf): cleanup the linting errors
Browse files Browse the repository at this point in the history
Fix up the lint errors after changing the Makefile to remove
the options to disable the linting errors. The Makefile change
is not committed in this PR request to allow the rest of the
protobuf files to build until all protobuf files are updated.

Fixed and updated the two files bgp.proto and cloudrpc.proto files
to address the follow lint error types. Also the generated files
are included in this PR.

    --disable-rule=core::0123
    --disable-rule=core::0131
    --disable-rule=core::0132
    --disable-rule=core::0133
    --disable-rule=core::0134
    --disable-rule=core::0140
    --disable-rule=core::0156
    --disable-rule=core::0158
    --disable-rule=core::0191
    --disable-rule=core::0192
    --disable-rule=core::0203
    --disable-rule=core::0216
    --disable-rule=client-libraries::4232::required-fields

Signed-off-by: Keith Wiles <keith.wiles@intel.com>
  • Loading branch information
KeithWiles committed Aug 8, 2024
1 parent 1239e12 commit 6a22970
Show file tree
Hide file tree
Showing 10 changed files with 2,930 additions and 2,887 deletions.
12 changes: 6 additions & 6 deletions network/cloud/cloudrpc.proto
Original file line number Diff line number Diff line change
Expand Up @@ -818,7 +818,7 @@ service CloudInfraService {
option (google.api.method_signature) = "name";
}
// List all OSPF Areas
rpc ListOspfArea(ListOspfAreaRequest) returns (ListOspfAreaResponse) {
rpc ListOspfAreas(ListOspfAreasRequest) returns (ListOspfAreasResponse) {
option (google.api.http) = {
get: "/v1alpha1/ospfAreas"
};
Expand Down Expand Up @@ -855,7 +855,7 @@ service CloudInfraService {
option (google.api.method_signature) = "name";
}
// List all OSPF IfNetworks
rpc ListOspfIfNetwork(ListOspfIfNetworkRequest) returns (ListOspfIfNetworkResponse) {
rpc ListOspfIfNetworks(ListOspfIfNetworksRequest) returns (ListOspfIfNetworksResponse) {
option (google.api.http) = {
get: "/v1alpha1/ospfIfNetworks"
};
Expand Down Expand Up @@ -2333,7 +2333,7 @@ message GetOspfAreaRequest {
}

// List OspfArea request
message ListOspfAreaRequest {
message ListOspfAreasRequest {
// parent
string parent = 1 [
(google.api.field_behavior) = REQUIRED,
Expand All @@ -2346,7 +2346,7 @@ message ListOspfAreaRequest {
}

// List OspfArea response
message ListOspfAreaResponse {
message ListOspfAreasResponse {
// list of ospf_areas
repeated OspfArea ospf_areas = 1;

Expand Down Expand Up @@ -2399,7 +2399,7 @@ message GetOspfIfNetworkRequest {
}

// List OspfIfNetwork request
message ListOspfIfNetworkRequest {
message ListOspfIfNetworksRequest {
// parent or IfNetwork identifier
string parent = 1 [
(google.api.field_behavior) = REQUIRED,
Expand All @@ -2412,7 +2412,7 @@ message ListOspfIfNetworkRequest {
}

// List OspfIfNetwork response
message ListOspfIfNetworkResponse {
message ListOspfIfNetworksResponse {
// list of OspfIfNetwork
repeated OspfIfNetwork ospf_if_networks = 1;
// next page token
Expand Down
2 changes: 1 addition & 1 deletion network/cloud/ospf.proto
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ message OSPFMD5Auth {
enum OSPFVersion {
// OSPF Version not specified and assume v2
OSPF_VERSION_UNSPECIFIED = 0;
// OSPF Verison 2
// OSPF Version 2
OSPF_VERSION_2 = 1;
// OSPF Version 3
OSPF_VERSION_3 = 2;
Expand Down
Loading

0 comments on commit 6a22970

Please sign in to comment.