Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(network): update readme to mermaid diagrams #443

Merged
merged 2 commits into from
Feb 28, 2024

Conversation

sandersms
Copy link
Contributor

Add additional use case content
Cleanup diagrams using drawio direct file inclusion

#86

@sandersms sandersms marked this pull request as ready for review February 23, 2024 17:53
@sandersms sandersms requested a review from a team as a code owner February 23, 2024 17:53
@sandersms sandersms linked an issue Feb 23, 2024 that may be closed by this pull request
Copy link
Member

@glimchb glimchb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sandersms
Copy link
Contributor Author

sandersms commented Feb 27, 2024

Diagram error not found error on the readme file when you click view file see https://github.com/opiproject/opi-api/blob/e6de02f10ddb5e1479f53c4584c8c6f08556b055/network/README.md#openconfig-model

Thanks, It is interesting that it renders in the preview in my editor; but, not on the github page. I need to track down what the issue is between the two.

Signed-off-by: Mark Sanders <marksanders194@gmail.com>
Signed-off-by: Mark Sanders <marksanders194@gmail.com>
@sandersms sandersms merged commit ccf4bb8 into opiproject:main Feb 28, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Network: Expand use case(s) for networking
2 participants