Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drag & drop interaction is broken #1626

Closed
BenHenning opened this issue Aug 12, 2020 · 4 comments · Fixed by #1627
Closed

Drag & drop interaction is broken #1626

BenHenning opened this issue Aug 12, 2020 · 4 comments · Fixed by #1627
Labels
Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@BenHenning
Copy link
Sponsor Member

BenHenning commented Aug 12, 2020

Describe the bug
When snapping together items in drag & drop, the items disappear.

To Reproduce
Steps to reproduce the behavior:

  1. Open app
  2. Open prototype exploration
  3. Play through to the second drag & drop interaction
  4. Click on the combine button to combine two elements
  5. See the items disappear.

Expected behavior
Items should snap together, not disappear.

Screen recording
broken_drag_drop_merge

Device

  • Device: Pixel XL
  • SDK version: 29

Additional context
This was reproed on an app build with the latest develop (5532009).

@BenHenning BenHenning added this to the Alpha milestone Aug 12, 2020
@BenHenning
Copy link
Sponsor Member Author

/cc @aggarwalpulkit596 as FYI.

@BenHenning
Copy link
Sponsor Member Author

Also: I noticed this when running StateFragmentTest--it correctly catches this issue.

@BenHenning
Copy link
Sponsor Member Author

BenHenning commented Aug 12, 2020

Seems to be caused by 5532009. This does not repro in d210f38.

/cc @anandwana001

@anandwana001
Copy link
Contributor

@rt4914

 Process: org.oppia.app, PID: 29591
    java.lang.IllegalStateException: Cannot call this method while RecyclerView is computing a layout or scrolling org.oppia.app.player.state.DragDropSortInteractionView{bf02918 VFED..... ......ID 0,94-1216,1070 #7f0900ef app:id/drag_drop_interaction_recycler_view}, adapter:org.oppia.app.recyclerview.BindableAdapter@256ff71, layout:androidx.recyclerview.widget.LinearLayoutManager@3456156, context:org.oppia.app.player.exploration.ExplorationActivity@97bd862
        at androidx.recyclerview.widget.RecyclerView.assertNotInLayoutOrScroll(RecyclerView.java:3051)
        at androidx.recyclerview.widget.RecyclerView$RecyclerViewDataObserver.onChanged(RecyclerView.java:5536)
        at androidx.recyclerview.widget.RecyclerView$AdapterDataObservable.notifyChanged(RecyclerView.java:12253)
        at androidx.recyclerview.widget.RecyclerView$Adapter.notifyDataSetChanged(RecyclerView.java:7354)
        at org.oppia.app.recyclerview.BindableAdapter.setData(BindableAdapter.kt:45)
        at org.oppia.app.recyclerview.BindableAdapter.setDataUnchecked(BindableAdapter.kt:68)
        at org.oppia.app.player.state.itemviewmodel.DragAndDropSortInteractionViewModel.onDragEnded(DragAndDropSortInteractionViewModel.kt:74)
        at org.oppia.app.databinding.DragDropInteractionItemBindingImpl._internalCallbackOnDragEnded(DragDropInteractionItemBindingImpl.java:277)
        at org.oppia.app.generated.callback.OnDragEndedListener.onDragEnded(OnDragEndedListener.java:11)
        at org.oppia.app.recyclerview.DragAndDropItemFacilitator.clearView(DragAndDropItemFacilitator.kt:38)

@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Z-ibt Temporary label for Ben to keep track of issues he's triaged.
2 participants