Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admin Controls icon color incorrect in API 19 #3722

Closed
rt4914 opened this issue Aug 24, 2021 · 31 comments
Closed

Admin Controls icon color incorrect in API 19 #3722

rt4914 opened this issue Aug 24, 2021 · 31 comments
Assignees
@rt4914
Labels
bug End user-perceivable behaviors which are not desirable. good first issue This item is good for new contributors to make their pull request. Impact: Low Low perceived user impact (e.g. edge cases). Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@rt4914
Copy link
Contributor

rt4914 commented Aug 24, 2021

In the screenshot we can notice that the icon color of Administrator Controls is orange even when its not selected. This needs to be fixed.

Expected behaviour:
Icon + Text color when selected -> Orange
Icon + Text color when not selected -> black

Take exact color code from colors.xml file and from other similar icons.
@rt4914 rt4914 added this to the Beta milestone Aug 24, 2021
@rt4914 rt4914 added good first issue This item is good for new contributors to make their pull request. Priority: Essential This work item must be completed for its milestone. Type: Improvement labels Aug 24, 2021
@aadityaguptaa
Copy link
Contributor

Hey, I think the expected API level is 21+ right?

@rt4914
Copy link
Contributor Author

rt4914 commented Aug 30, 2021

Hey, I think the expected API level is 21+ right?

@aadityaguptaa Actually for the minimum API version is 19.

@aadityaguptaa
Copy link
Contributor

Ohh okay, my bad. But the project uses OkHttp which works on API 21+. That's why my app keeps crashing.

@rt4914
Copy link
Contributor Author

rt4914 commented Aug 30, 2021

Ohh okay, my bad. But the project uses OkHttp which works on API 21+. That's why my app keeps crashing.

@aadityaguptaa Yes that's correct. I think I will have to solve this as there is one branch of mine in which I am not facing these crashes so I can leverage that to showcase that my solution works. @aadityaguptaa Can you pick some other issue to work on ?

@rt4914 rt4914 self-assigned this Aug 30, 2021
@aadityaguptaa
Copy link
Contributor

sure

@rt4914 rt4914 changed the title Admin Controls icon color incorrect in API 19 Admin Controls icon color incorrect in API 19 [Blocked on #3853] Sep 28, 2021
@rt4914 rt4914 removed their assignment Sep 28, 2021
@Rishavgupta12345
Copy link

please assign me this issue @rt4914 @bkaur-bkj

@bkaur-bkj
Copy link
Contributor

@Rishavgupta12345 Done

@Rishavgupta12345
Copy link

Rishavgupta12345 commented Nov 29, 2021 •
edited
Loading

can someone tell me on which file I can find this issue @rt4914

@BenHenning
Copy link
Member

@Rishavgupta12345 this is something that you'll need to investigate. One thing that can be really helpful is to look at strings on the screen that you're trying to find the code for, then look up those strings in code (which will correspond to string IDs), and then find which layouts/Kotlin files those strings are referenced in (which will either provide the exact files responsible for that screen, or the files responsible for a constituent piece of the screen).

@rt4914
Copy link
Contributor Author

rt4914 commented Dec 8, 2021 •
edited
Loading

This issue is specific to API 19 only. So please create an emulator accordingly.

@bkaur-bkj
Copy link
Contributor

@Rishavgupta12345 I have unassigned this issue as per your request, do let me know in case you want to pick it up again

@shubhanshu-coder
Copy link

pl assign me this issue @rt4914 @bkaur-bkj

@ArchitJain1201
Copy link
Contributor

@bkaur-bkj Can you please assign me this issue?

@bkaur-bkj
Copy link
Contributor

@bkaur-bkj Can you please assign me this issue?

as this issue is currently begin assigned to Shubhanshu you can try picking up other issues

@shubhanshu-coder
Copy link

shubhanshu-coder commented Jan 10, 2022 •
edited
Loading

can u pl guide me how to start , very eager to contribute.
currently figuring out where the issue code .

@rt4914
Copy link
Contributor Author

rt4914 commented Jan 19, 2022

can u pl guide me how to start , very eager to contribute. currently figuring out where the issue code .

@shubhanshu-coder Please checkout our wiki first. This will help you in setting up the project and once you sign the CLA and fill the survey form we can assign you issues to work on.

@ArchitJain1201
Copy link
Contributor

@shubhanshu-coder Are you still working on this issue or Can I take it?

@shubhanshu-coder
Copy link

shubhanshu-coder commented Feb 10, 2022 •
edited
Loading

@ArchitJain1201
Yes I am working on it.

@Broppia Broppia added issue_type_bug Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). labels Jun 13, 2022
@BenHenning BenHenning added Impact: Low Low perceived user impact (e.g. edge cases). TODO: need task force Z-ibt Temporary label for Ben to keep track of issues he's triaged. and removed Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). labels Sep 15, 2022
@BenHenning BenHenning removed this from the Beta milestone Sep 16, 2022
@deonwaju
Copy link
Collaborator

deonwaju commented Dec 8, 2022 •
edited
Loading

This issue seems to have been fixed, I checked the develop branch and its been fixed

@YesShubham01
Copy link

Yes this issue is fixed. I would like someone from community to close this issue.

@seanlip
Copy link
Member

seanlip commented Jan 3, 2023

@rt4914 is going to verify this and report back. Thanks for the ping.

@rt4914
Copy link
Contributor Author

rt4914 commented Jan 3, 2023

@YesShubham01 I did check this on latest develop code and it is still not fixed.

Device Config:
API 19 Kitkat
Pixel 2
Android 4.4 armeabi-v7a

Screenshot_20230103_171334

@rt4914 rt4914 changed the title Admin Controls icon color incorrect in API 19 [Blocked on #3853] Admin Controls icon color incorrect in API 19 Jan 3, 2023
@sumanbmondal
Copy link

sumanbmondal commented Feb 2, 2023 •
edited
Loading

@seanlip @rt4914 I think this is happening because the brown icon is selected for administrator controls. I am able to change it to grey icon. But I'm not able to change the color according to whether the button is selected or not.

I get the error "This feature requires ASM7" when I try to put conditionals -
image

Can you please help me, and if possible assign me the issue?

@nawaz-anwar
Copy link

@rt4914 I want to work on this issue. Please assign it to me.

@seanlip
Copy link
Member

seanlip commented Feb 8, 2023

@nawaz-anwar Please provide an explanation of what your PR will do (with names of files you're changing, what you plan to change in each file, etc.). If it looks good, we can assign you to this issue.

@sumanbmondal
Copy link

@seanlip @rt4914 I think this is happening because the brown icon is selected for administrator controls. I am able to change it to grey icon. But I'm not able to change the color according to whether the button is selected or not.

I get the error "This feature requires ASM7" when I try to put conditionals - image

Can you please help me, and if possible assign me the issue?

@seanlip @rt4914 Can you please comment on this?

@seanlip seanlip added bug End user-perceivable behaviors which are not desirable. and removed issue_user_learner labels Mar 29, 2023
@seanlip
Copy link
Member

seanlip commented Jun 4, 2023

Per #5012, we are deprecating support for Android KitKat, so this issue is no longer valid.

@seanlip seanlip closed this as not planned Won't fix, can't repro, duplicate, stale Jun 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rt4914 rt4914

Labels
bug End user-perceivable behaviors which are not desirable. good first issue This item is good for new contributors to make their pull request. Impact: Low Low perceived user impact (e.g. edge cases). Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests