Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Home Screen Greetings Message Line #582

Closed
rt4914 opened this issue Jan 3, 2020 · 2 comments
Closed

Home Screen Greetings Message Line #582

rt4914 opened this issue Jan 3, 2020 · 2 comments
Assignees
@rt4914
Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Milestone
0.4 Release Block...

Comments

@rt4914
Copy link
Contributor

rt4914 commented Jan 3, 2020 •
edited
Loading

Screenshot 2020-01-03 at 12 06 21 PM

In Home screen, there is a greetings message at the top of the screen, which is inflated using welcome.xml file

The line below that greeting should end at before the profilename as per mocks.

Update the code, so that the line exactly ends before ,

Also, if the name is too big and goes to second line, than in that case the line should be displayed below the name.
@rt4914 rt4914 self-assigned this Jan 3, 2020
@rt4914
Copy link
Contributor Author

rt4914 commented Jan 23, 2020

This PR should not be assigned to anyone, as there are still some doubts which needs to be discussed.

@veena14cs veena14cs mentioned this issue Jan 30, 2020
Merged
8 tasks
@BenHenning BenHenning added this to the Alpha milestone Jun 23, 2020
@BenHenning BenHenning added Type: Bug Priority: Essential This work item must be completed for its milestone. labels Jun 23, 2020
@rt4914
Copy link
Contributor Author

rt4914 commented Jun 24, 2020

This has been finished as a part of #954

@rt4914 rt4914 closed this as completed Jun 24, 2020
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rt4914 rt4914

Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
0.4 Release Blockers (Alpha MR1)
Development

No branches or pull requests
2 participants
@rt4914 @BenHenning