-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression with mkdocstrings>=23.0.0 dependency #8
Comments
Hmm it works for me, I don't observe the same error. You should share your site that exhibits this |
Let me know if you have more to share |
Hey! Just encountered the same issue with plugins:
- mkdocstrings:
docs_dir: . # this does nothing, but fixes the KeyError
# ...
# ... but that's not nice 😁 Here's a small site_name: Test
docs_dir: .
site_dir: ../site
repo_name: test-repo
plugins:
- same-dir
- mkdocstrings Notice that Also here's my [tool.poetry]
name = "repro"
version = "0.1.0"
description = ""
authors = []
[tool.poetry.dependencies]
python = "^3.9"
mkdocstrings = "0.24.0"
mkdocs-same-dir = "0.1.2"
[build-system]
requires = ["poetry-core"]
build-backend = "poetry.core.masonry.api" |
Thanks @vstrimaitis , I confirmed that this worked for me, although it does produce a warning |
I don't know why I wasn't able to reproduce it, but I think I understand why this happens and I'll release a fix now - in ~minutes |
New version works for me, thanks so much! |
Hello, thanks for this wonderful plugin!
I noticed my doc builds started failing whenever mkdocstrings was upgraded to 0.24.0. If I upgrade this package in my environment, the
same-dir
plugin fails with the following message:Thought I'd report this here for now since I'm not sure how another plugin would interfere with this one. For now I simply pin mkdocstrings to 0.23.0
The text was updated successfully, but these errors were encountered: